Messages in this thread Patch in this message | | | From | Beniamino Galvani <> | Subject | [PATCH] pwm: spear: fix check on pwmchip_add() return value | Date | Mon, 5 May 2014 23:29:00 +0200 |
| |
pwmchip_add() returns zero on success and a negative value on error, so the condition of the check must be inverted.
Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> --- drivers/pwm/pwm-spear.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c index cb2d4f0..945556d 100644 --- a/drivers/pwm/pwm-spear.c +++ b/drivers/pwm/pwm-spear.c @@ -222,7 +222,7 @@ static int spear_pwm_probe(struct platform_device *pdev) } ret = pwmchip_add(&pc->chip); - if (!ret) { + if (ret < 0) { clk_unprepare(pc->clk); dev_err(&pdev->dev, "pwmchip_add() failed: %d\n", ret); } -- 1.7.10.4
| |