Messages in this thread | | | Date | Wed, 7 May 2014 10:49:00 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH] pwm: spear: fix check on pwmchip_add() return value |
| |
On Wed, May 07, 2014 at 02:02:24PM +0530, Viresh Kumar wrote: > On 7 May 2014 13:54, Thierry Reding <thierry.reding@gmail.com> wrote: > > So the current code would run clk_unprepare() on success, but not on > > failure. Does that cause any harm? > > Yeah, that would make the device unusable as clk_enable will always fail.
Hmm... so ever since this driver was merged in 3.8 it was completely broken and nobody noticed? Interesting.
> > Is the device still usable after this? > > Yes, this will fix the bug. > > > I'm asking because I'm not sure if this is linux-next material > > or should be a fix for 3.15 (and possibly backported to stable). > > IMO, it should be sent for stable: v3.8+
Since this was obviously broken since 3.8 and nobody noticed I wonder if there's really an urgent need for this in stable.
Thierry [unhandled content-type:application/pgp-signature] | |