Messages in this thread | | | Date | Wed, 7 May 2014 14:02:24 +0530 | Subject | Re: [PATCH] pwm: spear: fix check on pwmchip_add() return value | From | Viresh Kumar <> |
| |
On 7 May 2014 13:54, Thierry Reding <thierry.reding@gmail.com> wrote: > So the current code would run clk_unprepare() on success, but not on > failure. Does that cause any harm?
Yeah, that would make the device unusable as clk_enable will always fail.
> Is the device still usable after this?
Yes, this will fix the bug.
> I'm asking because I'm not sure if this is linux-next material > or should be a fix for 3.15 (and possibly backported to stable).
IMO, it should be sent for stable: v3.8+
| |