lkml.org 
[lkml]   [2014]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] gpio: dwapb: use a second irq chip
On 03/25/2014 10:36 PM, Sebastian Hesselbarth wrote:
>> @@ -242,17 +244,28 @@ static void dwapb_configure_irqs(struct dwapb_gpio *gpio,
>> irq_gc->reg_base = gpio->regs;
>> irq_gc->private = gpio;
>>
>> - ct = irq_gc->chip_types;
>> - ct->chip.irq_ack = irq_gc_ack_set_bit;
>> - ct->chip.irq_mask = irq_gc_mask_set_bit;
>> - ct->chip.irq_unmask = irq_gc_mask_clr_bit;
>> - ct->chip.irq_set_type = dwapb_irq_set_type;
>> - ct->chip.irq_enable = dwapb_irq_enable;
>> - ct->chip.irq_disable = dwapb_irq_disable;
>> - ct->chip.irq_request_resources = dwapb_irq_reqres;
>> - ct->chip.irq_release_resources = dwapb_irq_relres;
>> - ct->regs.ack = GPIO_PORTA_EOI;
>> - ct->regs.mask = GPIO_INTMASK;
>> + for (i = 0; i < 2; i++) {
>> +
>> + ct = &irq_gc->chip_types[i];
>> + ct->chip.irq_ack = irq_gc_ack_set_bit;
>> + ct->chip.irq_mask = irq_gc_mask_set_bit;
>> + ct->chip.irq_unmask = irq_gc_mask_clr_bit;
>> + ct->chip.irq_set_type = dwapb_irq_set_type;
>> + ct->chip.irq_enable = dwapb_irq_enable;
>> + ct->chip.irq_disable = dwapb_irq_disable;
>> + ct->chip.irq_request_resources = dwapb_irq_reqres;
>> + ct->chip.irq_release_resources = dwapb_irq_relres;
>> + ct->regs.ack = GPIO_PORTA_EOI;
>> + ct->regs.mask = GPIO_INTMASK;
>> +
>> + if (i == 0) {
>> + ct->type = IRQ_TYPE_LEVEL_MASK;
>> + ct->handler = handle_level_irq;
>> + } else {
>> + ct->type = IRQ_TYPE_EDGE_BOTH;
>> + ct->handler = handle_edge_irq;
>> + }
>
> Sebastian,
>
> IMHO the loop looks strange, especially with the (i == 0) check.

how so?

> How about unrolling it again and assign both chip_types independently?

If more code makes you happy so be it. I will post the series soon with
the loop unrolled.

> Sebastian

Sebastian


\
 
 \ /
  Last update: 2014-04-07 12:41    [W:0.265 / U:1.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site