lkml.org 
[lkml]   [2014]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] gpio: dwapb: use d->mask instead od BIT(bit)
On 03/25/2014 03:17 AM, Alexandre Courbot wrote:
>> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
>> index 3c9cdda..ebfcf5c 100644
>> --- a/drivers/gpio/gpio-dwapb.c
>> +++ b/drivers/gpio/gpio-dwapb.c
>> @@ -126,7 +126,7 @@ static void dwapb_irq_disable(struct irq_data *d)
>>
>> irq_gc_lock(igc);
>> val = readl(gpio->regs + GPIO_INTEN);
>> - val &= ~BIT(d->hwirq);
>> + val &= d->mask;
>
> Shouldn't that be ~d->mask here?

Yes, indeed. Thanks for catching this.

Sebastian


\
 
 \ /
  Last update: 2014-03-25 09:21    [W:0.191 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site