| Date | Tue, 25 Mar 2014 08:54:58 +0100 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH 7/7] gpio: dwapb: use d->mask instead od BIT(bit) |
| |
On 03/25/2014 03:17 AM, Alexandre Courbot wrote: >> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c >> index 3c9cdda..ebfcf5c 100644 >> --- a/drivers/gpio/gpio-dwapb.c >> +++ b/drivers/gpio/gpio-dwapb.c >> @@ -126,7 +126,7 @@ static void dwapb_irq_disable(struct irq_data *d) >> >> irq_gc_lock(igc); >> val = readl(gpio->regs + GPIO_INTEN); >> - val &= ~BIT(d->hwirq); >> + val &= d->mask; > > Shouldn't that be ~d->mask here?
Yes, indeed. Thanks for catching this.
Sebastian
|