lkml.org 
[lkml]   [2014]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 7/7] gpio: dwapb: use d->mask instead od BIT(bit)
On Sun, Mar 23, 2014 at 1:16 AM, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> d->mask contains exact the same information as BIT(bit) so we could save
> a few cycles here.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> drivers/gpio/gpio-dwapb.c | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index 3c9cdda..ebfcf5c 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -113,7 +113,7 @@ static void dwapb_irq_enable(struct irq_data *d)
>
> irq_gc_lock(igc);
> val = readl(gpio->regs + GPIO_INTEN);
> - val |= BIT(d->hwirq);
> + val |= d->mask;
> writel(val, gpio->regs + GPIO_INTEN);
> irq_gc_unlock(igc);
> }
> @@ -126,7 +126,7 @@ static void dwapb_irq_disable(struct irq_data *d)
>
> irq_gc_lock(igc);
> val = readl(gpio->regs + GPIO_INTEN);
> - val &= ~BIT(d->hwirq);
> + val &= d->mask;

Shouldn't that be ~d->mask here?


\
 
 \ /
  Last update: 2014-03-25 04:01    [W:0.893 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site