Messages in this thread | | | Subject | Re: [PATCH v2][RESENT] dma: add R-Car Audio DMAC peri peri driver | From | Joe Perches <> | Date | Sun, 09 Mar 2014 18:47:02 -0700 |
| |
On Sun, 2014-03-09 at 18:34 -0700, Kuninori Morimoto wrote: > Add support Audio DMAC peri peri driver > for Renesas R-Car Gen2 SoC, using 'shdma-base' > DMA driver framework.
Trivial notes:
> diff --git a/drivers/dma/sh/rcar-audmapp.c b/drivers/dma/sh/rcar-audmapp.c [] > +static int audmapp_chan_probe(struct platform_device *pdev, > + struct audmapp_device *audev, int id) > +{ [] > + auchan = devm_kzalloc(dev, sizeof(struct audmapp_chan), GFP_KERNEL); > + if (!auchan) { > + dev_err(dev, "No free memory for allocating dma channels!\n");
Unnecessary OOM as the alloc has a generic OOM and a dump_stack()
[] > +static int audmapp_probe(struct platform_device *pdev) > +{ [] > + audev = devm_kzalloc(&pdev->dev, sizeof(struct audmapp_device), > + GFP_KERNEL); > + if (!audev) { > + dev_err(&pdev->dev, "Not enough memory\n");
here too
| |