Messages in this thread | | | Date | Fri, 24 Jan 2014 09:33:49 +0100 | Subject | Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver | From | Geert Uytterhoeven <> |
| |
Hi Morimoto-san,
On Fri, Jan 24, 2014 at 9:18 AM, Kuninori Morimoto <kuninori.morimoto.gx@gmail.com> wrote: >> > + if (slave_id >= AUDMAPP_SLAVE_NUMBER) >> >> So slave_id should be unsigned int, too, and AUDMAPP_SLAVE_NUMBER >> too ("29U"). > > Hmm... > This driver is called from shdma-base.c. > And shdmac.c/sudmac.c/rcar-hpbdmac.c are same style. > > 1) this "slave_id" came from shdma_ops::set_slave > and, it is using "int" > 2) above drivers have same xxx_find_slave(), > they are using "int". > (this driver is based on that) > > What should I do ?
OK, then you should keep using int, and change the test to:
if (slave_id < 0 || slave_id >= AUDMAPP_SLAVE_NUMBER)
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |