Messages in this thread | | | Date | Fri, 24 Jan 2014 00:58:46 -0800 (PST) | From | Kuninori Morimoto <> | Subject | Re: [PATCH] shdma: add R-Car Audio DMAC peri peri driver |
| |
Hi Geert
> > This driver is called from shdma-base.c. > > And shdmac.c/sudmac.c/rcar-hpbdmac.c are same style. > > > > 1) this "slave_id" came from shdma_ops::set_slave > > and, it is using "int" > > 2) above drivers have same xxx_find_slave(), > > they are using "int". > > (this driver is based on that) > > > > What should I do ? > > OK, then you should keep using int, and change the test to: > > if (slave_id < 0 || slave_id >= AUDMAPP_SLAVE_NUMBER)
I see Thank you
Best regards --- Kuninori Morimoto
| |