lkml.org 
[lkml]   [2014]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2][RESENT] dma: add R-Car Audio DMAC peri peri driver

Hi Joe

> > diff --git a/drivers/dma/sh/rcar-audmapp.c b/drivers/dma/sh/rcar-audmapp.c
> []
> > +static int audmapp_chan_probe(struct platform_device *pdev,
> > + struct audmapp_device *audev, int id)
> > +{
> []
> > + auchan = devm_kzalloc(dev, sizeof(struct audmapp_chan), GFP_KERNEL);
> > + if (!auchan) {
> > + dev_err(dev, "No free memory for allocating dma channels!\n");
>
> Unnecessary OOM as the alloc has a generic OOM
> and a dump_stack()
>
> []
> > +static int audmapp_probe(struct platform_device *pdev)
> > +{
> []
> > + audev = devm_kzalloc(&pdev->dev, sizeof(struct audmapp_device),
> > + GFP_KERNEL);
> > + if (!audev) {
> > + dev_err(&pdev->dev, "Not enough memory\n");
>
> here too

Thank you.
will fix in v3


\
 
 \ /
  Last update: 2014-03-10 04:01    [W:0.065 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site