Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS | Date | Thu, 06 Mar 2014 13:13:55 +0000 |
| |
David Howells <dhowells@redhat.com> wrote:
> > Can we have something like this for 'flags'? > > There's a __print_flags() which should work. One thing I'm concerned about > there is how do we handle more flags being added - does that count as an ABI > break if the printed format changes? > > SMBus flags are basically the same as I2C flags, right?
Hmmm... __print_flags() seems to append a string if a flag is set, and doesn't if it isn't set. It places a separator between each string. I would prefer something that emits a single char per flag or a dash if it isn't present. Are you okay with that?
David
| |