Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS | Date | Thu, 27 Feb 2014 13:19:38 +0000 |
| |
Wolfram Sang <wsa@the-dreams.de> wrote:
> Although SMBus has no 10-bit addresses, we probably should also use %03x > there for consistency reasons?
Done.
> Also, the I2C tracing has first 'f' then 'a', that should be consistent, > too.
Flags first or address first? Do you have a preference (for both)?
> 'flags' should be %04x again
Done.
> and I'd prefer %*ph (or %*phD) for the buffer.
Again, I'm not so certain.
> Can we have something like this for 'flags'?
There's a __print_flags() which should work. One thing I'm concerned about there is how do we handle more flags being added - does that count as an ABI break if the printed format changes?
SMBus flags are basically the same as I2C flags, right?
David
| |