lkml.org 
[lkml]   [2014]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS
On Thu, Mar 06, 2014 at 01:13:55PM +0000, David Howells wrote:
> David Howells <dhowells@redhat.com> wrote:
>
> > > Can we have something like this for 'flags'?
> >
> > There's a __print_flags() which should work. One thing I'm concerned about
> > there is how do we handle more flags being added - does that count as an ABI
> > break if the printed format changes?
> >
> > SMBus flags are basically the same as I2C flags, right?
>
> Hmmm... __print_flags() seems to append a string if a flag is set, and doesn't
> if it isn't set. It places a separator between each string. I would prefer
> something that emits a single char per flag or a dash if it isn't present.
> Are you okay with that?

Yes, that's good, too!

Thanks!

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-03-06 15:02    [W:0.058 / U:1.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site