Messages in this thread | | | Date | Tue, 18 Feb 2014 21:54:18 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS |
| |
> + TP_printk("i2c-%d a=%02x f=%02x c=%x %s l=%u [%*phN]",
Although SMBus has no 10-bit addresses, we probably should also use %03x there for consistency reasons?
Also, the I2C tracing has first 'f' then 'a', that should be consistent, too.
'flags' should be %04x again and I'd prefer %*ph (or %*phD) for the buffer.
> + __print_symbolic(__entry->protocol, > + { I2C_SMBUS_QUICK, "QUICK" }, > + { I2C_SMBUS_BYTE, "BYTE" }, > + { I2C_SMBUS_BYTE_DATA, "BYTE_DATA" }, > + { I2C_SMBUS_WORD_DATA, "WORD_DATA" }, > + { I2C_SMBUS_PROC_CALL, "PROC_CALL" }, > + { I2C_SMBUS_BLOCK_DATA, "BLOCK_DATA" }, > + { I2C_SMBUS_I2C_BLOCK_BROKEN, "I2C_BLOCK_BROKEN" }, > + { I2C_SMBUS_BLOCK_PROC_CALL, "BLOCK_PROC_CALL" }, > + { I2C_SMBUS_I2C_BLOCK_DATA, "I2C_BLOCK_DATA" }),
Can we have something like this for 'flags'?
[unhandled content-type:application/pgp-signature]
| |