lkml.org 
[lkml]   [2014]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip v8 17/26] notifier: Use NOKPROBE_SYMBOL macro in notifier
(2014/03/25 5:12), Steven Rostedt wrote:
> On Wed, 05 Mar 2014 21:00:42 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>> Use NOKPROBE_SYMBOL macro to protect functions from
>> kprobes instead of __kprobes annotation in notifier.
>>
>> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>
>> /*
>> * Blocking notifier chain routines. All access to the chain is
>> @@ -527,7 +530,7 @@ EXPORT_SYMBOL_GPL(srcu_init_notifier_head);
>>
>> static ATOMIC_NOTIFIER_HEAD(die_chain);
>>
>> -int notrace __kprobes notify_die(enum die_val val, const char *str,
>> +int notrace notify_die(enum die_val val, const char *str,
>
> Hmm, I wonder why notify_die() is marked notrace? But that's unrelated
> to this patch.
>
> Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

Thanks! I guess since notify_die() is called from any kind of fault,
which may be happen inside ftrace too.

Thank you,

--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com




\
 
 \ /
  Last update: 2014-03-25 12:01    [W:0.928 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site