| Date | Mon, 24 Mar 2014 15:38:30 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH -tip v8 12/26] ftrace/*probes: Allow probing on some functions |
| |
On Wed, 05 Mar 2014 21:00:07 +0900 Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> --- a/kernel/trace/trace_kprobe.c > +++ b/kernel/trace/trace_kprobe.c > @@ -1209,7 +1209,7 @@ kretprobe_perf_func(struct trace_kprobe *tk, struct kretprobe_instance *ri, > * kprobe_trace_self_tests_init() does enable_trace_probe/disable_trace_probe > * lockless, but we can't race with this __init function. > */ > -static __kprobes > +static > int kprobe_register(struct ftrace_event_call *event,
Please keep the static on the same line as int. Either the above is one line or:
static int kprobe_register(...)
Like the rest of the patch does.
-- Steve
|