lkml.org 
[lkml]   [2014]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip v8 12/26] ftrace/*probes: Allow probing on some functions
(2014/03/25 4:38), Steven Rostedt wrote:
> On Wed, 05 Mar 2014 21:00:07 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>> --- a/kernel/trace/trace_kprobe.c
>> +++ b/kernel/trace/trace_kprobe.c
>> @@ -1209,7 +1209,7 @@ kretprobe_perf_func(struct trace_kprobe *tk, struct kretprobe_instance *ri,
>> * kprobe_trace_self_tests_init() does enable_trace_probe/disable_trace_probe
>> * lockless, but we can't race with this __init function.
>> */
>> -static __kprobes
>> +static
>> int kprobe_register(struct ftrace_event_call *event,
>
> Please keep the static on the same line as int. Either the above is one
> line or:
>
> static int
> kprobe_register(...)
>
> Like the rest of the patch does.

I see, I'll update it. :)

Thank you,

>
> -- Steve
>
>


--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com




\
 
 \ /
  Last update: 2014-03-25 11:21    [W:0.533 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site