lkml.org 
[lkml]   [2014]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip v8 08/26] kprobes/x86: Call exception handlers directly from do_int3/do_debug
On Mon, 24 Mar 2014 17:47:06 +0900
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:

> >> @@ -857,7 +857,7 @@ no_change:
> >> * Interrupts are disabled on entry as trap1 is an interrupt gate and they
> >> * remain disabled throughout this function.
> >> */
> >> -static int __kprobes post_kprobe_handler(struct pt_regs *regs)
> >> +int __kprobes kprobe_debug_handler(struct pt_regs *regs)


> >> - break;
> >> - case DIE_DEBUG:
> >> - if (post_kprobe_handler(args->regs)) {

> >
> > The DIE_DEBUG case is removed but not added anyplace else. The change
> > log doesn't say why this was removed.
>
> As you can see the above hunk, post_kprobe_handler() is now renamed
> as kprobe_debug_handler() which is called from do_debug() directly.
>
> What I meant in the patch comment;
>
> >> To avoid a kernel crash by probing on lockdep code, call
> >> kprobe_int3_handler and kprobe_debug_handler directly
> >> from do_int3 and do_debug.
>
> was actually pointing that change...
>


I missed the rename of post_kprobe_handler().

Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve


\
 
 \ /
  Last update: 2014-03-24 20:41    [W:0.079 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site