lkml.org 
[lkml]   [2014]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] mfd: MAX6650/6651 support
On Wed, Feb 12, 2014 at 04:02:40AM +0000, Laszlo Papp wrote:

> +const struct regmap_config max665x_regmap_config = {
> + .reg_bits = 5,
> +};

This would normally be static too, and I'd *really* expect to see a
val_bits set here. I'm a bit surprised this works without one.

> + mutex_init(&max665x->iolock);

What is this needed for?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-02-12 19:41    [W:0.301 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site