Messages in this thread |  | | Date | Thu, 13 Feb 2014 08:23:11 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v6] mfd: MAX6650/6651 support |
| |
Laszlo,
> > +const struct regmap_config max665x_regmap_config = { > > + .reg_bits = 5, > > +}; > > This would normally be static too, and I'd *really* expect to see a > val_bits set here. I'm a bit surprised this works without one.
Mark (privately) mentioned to me that this patch can't possibly work given the current Regmap configuration. Patches are accepted into Mainline based on the premise that they are fully tested and working, _prior_ to submitting [1].
It's also pretty pointless having an MFD driver without any children, so unless (at least one of) the child device drivers have been accepted by pull-time, your work will not be part of the pull-request headed for Mainline.
Please inform me of your plans as you with to proceed.
[] Documentation/SubmitChecklist
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |