Messages in this thread | | | Date | Wed, 12 Feb 2014 08:32:24 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v6] mfd: MAX6650/6651 support |
| |
> >> + max665x->map = devm_regmap_init_i2c(i2c, &max665x_regmap_config); > > > > Don't you need to check the return value of devm_regmap_init_i2c? > > I personally think I should. I strived for consistency though with > other similar drivers. After this many reviews about such things, it > seems that consistency matters here less than other projects which I > can cope with, thanks.
The right thing to do is normally preferred.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |