lkml.org 
[lkml]   [2014]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V2 05/15] genirq: Generic chip: Add big endian I/O accessors
Date
On Wednesday 29 October 2014 19:17:58 Kevin Cernekee wrote:
> static LIST_HEAD(gc_list);
> static DEFINE_RAW_SPINLOCK(gc_lock);
>
> +static int is_big_endian(struct irq_chip_generic *gc)
> +{
> + return !!(gc->domain->gc->gc_flags & IRQ_GC_BE_IO);
> +}
> +
> static void irq_reg_writel(struct irq_chip_generic *gc,
> u32 val, int reg_offset)
> {
> - writel(val, gc->reg_base + reg_offset);
> + if (is_big_endian(gc))
> + iowrite32be(val, gc->reg_base + reg_offset);
> + else
> + writel(val, gc->reg_base + reg_offset);
> }
>

What I had in mind was to use indirect function calls instead, like

#ifndef irq_reg_writel
static inline void irq_reg_writel_le(u32 val, void __iomem *addr)
{
return writel(val, addr);
}
#endif

#ifndef irq_reg_writel_be
static inline void irq_reg_writel_be(u32 val, void __iomem *addr)
{
return iowrite32_be(val, addr);
}
#endif


static inline void irq_reg_writel(struct irq_chip_generic *gc, u32 val, int reg_offset)
{
if (IS_ENABLED(CONFIG_GENERIC_IRQ_CHIP) &&
!IS_ENABLED(CONFIG_GENERIC_IRQ_CHIP_BE))
return irq_reg_writel_le(val, gc->reg_base + reg_offset);

if (IS_ENABLED(CONFIG_GENERIC_IRQ_CHIP) &&
!IS_ENABLED(CONFIG_GENERIC_IRQ_CHIP_BE))
return irq_reg_writel_be(val, gc->reg_base + reg_offset);

return gc->writel(val, gc->reg_base + reg_offset);
}

This would take the condition out of the callers.

Arnd


\
 
 \ /
  Last update: 2014-10-30 11:01    [W:1.244 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site