lkml.org 
[lkml]   [2014]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V2 02/15] sh: Eliminate unused irq_reg_{readl,writel} accessors
Date
On Wednesday 29 October 2014 19:17:55 Kevin Cernekee wrote:
> Defining these macros way down in arch/sh/.../irq.c doesn't cause
> kernel/irq/generic-chip.c to use them. As far as I can tell this code
> has no effect.
>
> Signed-off-by: Kevin Cernekee <cernekee@gmail.com>

Actually it overrides the 32-bit accessors with 16-bit accessors,
which does seem intentional and certainly has an effect.

Arnd

> arch/sh/boards/mach-se/7343/irq.c | 3 ---
> arch/sh/boards/mach-se/7722/irq.c | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/arch/sh/boards/mach-se/7343/irq.c b/arch/sh/boards/mach-se/7343/irq.c
> index 7646bf0..1087dba 100644
> --- a/arch/sh/boards/mach-se/7343/irq.c
> +++ b/arch/sh/boards/mach-se/7343/irq.c
> @@ -14,9 +14,6 @@
> #define DRV_NAME "SE7343-FPGA"
> #define pr_fmt(fmt) DRV_NAME ": " fmt
>
> -#define irq_reg_readl ioread16
> -#define irq_reg_writel iowrite16
> -
> #include <linux/init.h>
> #include <linux/irq.h>
> #include <linux/interrupt.h>



\
 
 \ /
  Last update: 2014-10-30 10:21    [W:0.158 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site