| From | Arnd Bergmann <> | Subject | Re: [PATCH V2 10/15] irqchip: bcm7120-l2: Make sure all register accesses use base+offset | Date | Thu, 30 Oct 2014 10:12:30 +0100 |
| |
On Wednesday 29 October 2014 19:18:03 Kevin Cernekee wrote: > A couple of accesses to IRQEN (base+0x00) just used "base" directly, so > they would break if IRQEN ever became nonzero. Make sure that all > reads/writes specify the register offset constant. > > Signed-off-by: Kevin Cernekee <cernekee@gmail.com> > Acked-by: Florian Fainelli <f.fainelli@gmail.com> >
Now you no longer convert them this driver to use irq_reg_{readl,writel}, which breaks support for big-endian ARM.
Arnd
|