lkml.org 
[lkml]   [2014]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V2 15/15] irqchip: bcm7120-l2: Enable big endian register accesses on BE kernels
Date
On Wednesday 29 October 2014 19:18:08 Kevin Cernekee wrote:
>
> + flags = IRQ_GC_INIT_MASK_CACHE;
> + if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
> + flags |= IRQ_GC_BE_IO;
> +
>

As I said before, I think you should take this from a DT property instead
of making it dependent on the CPU endianess. Otherwise things go horribly
wrong e.g. when someone runs a big-endian kernel on one of the ARM
based chips.

Arnd


\
 
 \ /
  Last update: 2014-10-30 10:21    [W:1.495 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site