Messages in this thread Patch in this message | | | Date | Tue, 14 Jan 2014 08:41:43 -0800 | From | tip-bot for Ramkumar Ramachandra <> | Subject | [tip:perf/core] perf tools: Generalize percent_color_snprintf() |
| |
Commit-ID: f77c6e9c8f9c444cd44423df0c2708e86a06a696 Gitweb: http://git.kernel.org/tip/f77c6e9c8f9c444cd44423df0c2708e86a06a696 Author: Ramkumar Ramachandra <artagnon@gmail.com> AuthorDate: Mon, 30 Dec 2013 13:04:18 +0530 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Mon, 13 Jan 2014 10:46:39 -0300
perf tools: Generalize percent_color_snprintf()
Make percent_color_snprintf() handle negative values correctly.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Link: http://lkml.kernel.org/r/1388388861-7931-2-git-send-email-artagnon@gmail.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/color.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/color.c b/tools/perf/util/color.c index 66e44a5..8cda46c 100644 --- a/tools/perf/util/color.c +++ b/tools/perf/util/color.c @@ -1,6 +1,7 @@ #include <linux/kernel.h> #include "cache.h" #include "color.h" +#include <math.h> int perf_use_color_default = -1; @@ -298,10 +299,10 @@ const char *get_percent_color(double percent) * entries in green - and keep the low overhead places * normal: */ - if (percent >= MIN_RED) + if (fabs(percent) >= MIN_RED) color = PERF_COLOR_RED; else { - if (percent > MIN_GREEN) + if (fabs(percent) > MIN_GREEN) color = PERF_COLOR_GREEN; } return color;
| |