lkml.org 
[lkml]   [2013]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 4/4] perf diff: color the Weighted Diff column
Ramkumar Ramachandra wrote:
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index c07cd3c..9c69620 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -777,6 +777,7 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
> container_of(fmt, struct diff_hpp_fmt, fmt);
> struct hist_entry *pair = get_pair_fmt(he, dfmt);
> double diff;
> + s64 wdiff;
> char pfmt[20] = " ";
>
> if (!pair)
> @@ -805,6 +806,17 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt,
> scnprintf(pfmt, 20, "%%%d.6f", dfmt->header_width);
> return value_color_snprintf(hpp->buf, hpp->size,
> pfmt, diff);
> + case COMPUTE_WEIGHTED_DIFF:
> + if (he->dummy)
> + goto dummy_print;
> + if (pair->diff.computed)
> + wdiff = pair->diff.wdiff;
> + else
> + wdiff = compute_wdiff(he, pair);
> +
> + scnprintf(pfmt, 20, "%%14ld", dfmt->header_width);
> + return value_color_snprintf(hpp->buf, hpp->size,
> + pfmt, wdiff);

Oops, I sent this out too fast. value_color_snprintf() accepts a
double, but wdiff is an s64. As a result, the wdiff column is
populated with zeros.

Will resend.


\
 
 \ /
  Last update: 2013-12-30 09:41    [W:0.122 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site