Messages in this thread Patch in this message | | | From | Ramkumar Ramachandra <> | Subject | [PATCH v6 1/4] perf tools: generalize percent_color_snprintf() | Date | Mon, 30 Dec 2013 13:04:18 +0530 |
| |
Make percent_color_snprintf() handle negative values correctly.
Cc: Jiri Olsa <jolsa@redhat.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> --- tools/perf/util/color.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/color.c b/tools/perf/util/color.c index 66e44a5..8cda46c 100644 --- a/tools/perf/util/color.c +++ b/tools/perf/util/color.c @@ -1,6 +1,7 @@ #include <linux/kernel.h> #include "cache.h" #include "color.h" +#include <math.h> int perf_use_color_default = -1; @@ -298,10 +299,10 @@ const char *get_percent_color(double percent) * entries in green - and keep the low overhead places * normal: */ - if (percent >= MIN_RED) + if (fabs(percent) >= MIN_RED) color = PERF_COLOR_RED; else { - if (percent > MIN_GREEN) + if (fabs(percent) > MIN_GREEN) color = PERF_COLOR_GREEN; } return color; -- 1.8.5.2.227.g53f3478
| |