Messages in this thread Patch in this message | | | From | Ramkumar Ramachandra <> | Subject | [PATCH v7] perf diff: color the Weighted Diff column | Date | Mon, 30 Dec 2013 13:32:35 +0530 |
| |
In
$ perf diff -c wdiff:M,N
color the numbers in the Weighted Diff column using color_snprintf(), picking the colors using get_percent_color().
Cc: Jiri Olsa <jolsa@redhat.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> --- In v6, I made the blunder of using value_color_snprintf(), zeroing out the numbers in the wdiff column. This iteration calls get_percent_color() by hand, making sure that the last s64 argument is not coerced into a double.
tools/perf/builtin-diff.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c index c07cd3c..a1a5dfb 100644 --- a/tools/perf/builtin-diff.c +++ b/tools/perf/builtin-diff.c @@ -777,6 +777,7 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt, container_of(fmt, struct diff_hpp_fmt, fmt); struct hist_entry *pair = get_pair_fmt(he, dfmt); double diff; + s64 wdiff; char pfmt[20] = " "; if (!pair) @@ -805,6 +806,18 @@ static int __hpp__color_compare(struct perf_hpp_fmt *fmt, scnprintf(pfmt, 20, "%%%d.6f", dfmt->header_width); return value_color_snprintf(hpp->buf, hpp->size, pfmt, diff); + case COMPUTE_WEIGHTED_DIFF: + if (he->dummy) + goto dummy_print; + if (pair->diff.computed) + wdiff = pair->diff.wdiff; + else + wdiff = compute_wdiff(he, pair); + + scnprintf(pfmt, 20, "%%14ld", dfmt->header_width); + return color_snprintf(hpp->buf, hpp->size, + get_percent_color(wdiff), + pfmt, wdiff); default: BUG_ON(1); } @@ -825,6 +838,12 @@ static int hpp__color_ratio(struct perf_hpp_fmt *fmt, return __hpp__color_compare(fmt, hpp, he, COMPUTE_RATIO); } +static int hpp__color_wdiff(struct perf_hpp_fmt *fmt, + struct perf_hpp *hpp, struct hist_entry *he) +{ + return __hpp__color_compare(fmt, hpp, he, COMPUTE_WEIGHTED_DIFF); +} + static void hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size) { @@ -1006,6 +1025,9 @@ static void data__hpp_register(struct data__file *d, int idx) case PERF_HPP_DIFF__RATIO: fmt->color = hpp__color_ratio; break; + case PERF_HPP_DIFF__WEIGHTED_DIFF: + fmt->color = hpp__color_wdiff; + break; default: break; } -- 1.8.5.2.227.g53f3478
| |