Messages in this thread | | | Date | Tue, 9 Apr 2013 20:12:56 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 7/8] dmaengine: ste_dma40: Use the BIT macro to replace ugly '(1 << x)'s |
| |
On Tue, 09 Apr 2013, Harvey Harrison wrote:
> On Tue, Apr 9, 2013 at 11:39 AM, Lee Jones <lee.jones@linaro.org> wrote: > > > > The aim is to make the code that little more readable. > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > > > > #define MAX(a, b) (((a) < (b)) ? (b) : (a)) > > Not part of your patch, but probably a good idea to switch to the > generic MAX macro, this > one is evaluating its args twice.
Sure, thanks for the heads-up.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |