Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 7/8] dmaengine: ste_dma40: Use the BIT macro to replace ugly '(1 << x)'s | Date | Tue, 9 Apr 2013 21:12:55 +0200 |
| |
On Tuesday 09 April 2013, Harvey Harrison wrote: > > On Tue, Apr 9, 2013 at 11:39 AM, Lee Jones <lee.jones@linaro.org> wrote: > > > > The aim is to make the code that little more readable. > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > > > > #define MAX(a, b) (((a) < (b)) ? (b) : (a)) > > Not part of your patch, but probably a good idea to switch to the > generic MAX macro, this > one is evaluating its args twice.
Yes, good point. The macro is only used in one place, to compare two compile-time constant values, but we should define macros in drivers that are already provided by the kernel.
Arnd
| |