Messages in this thread | | | Date | Wed, 24 Apr 2013 15:45:37 +0200 | Subject | Re: [PATCH 1/8] dmaengine: ste_dma40: Assign memcpy channels in the driver | From | Linus Walleij <> |
| |
On Tue, Apr 9, 2013 at 8:39 PM, Lee Jones <lee.jones@linaro.org> wrote:
> The channels reserved for memcpy are the same for all currently > supported platforms. With this in mind, we can ease the platform > data passing requirement by moving these assignments out from > platform code and place them directly into the driver. > > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: Dan Williams <djbw@fb.com> > Cc: Per Forlin <per.forlin@stericsson.com> > Acked-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
(...)
> -/* Reserved event lines for memcpy only */ > -static int dma40_memcpy_event[] = { > - DB8500_DMA_MEMCPY_TX_0, > - DB8500_DMA_MEMCPY_TX_1, > - DB8500_DMA_MEMCPY_TX_2, > - DB8500_DMA_MEMCPY_TX_3, > - DB8500_DMA_MEMCPY_TX_4, > - DB8500_DMA_MEMCPY_TX_5, > -};
(...)
> +/* Reserved event lines for memcpy only. */ > +static int dma40_memcpy_channels[] = { 56, 57, 58, 59, 60 };
So what's so bad with using the #defines?
I would prefer if you took the entire content of arch/arm/mach-ux500/ste-dma40-db8500.h and copied into the DMA driver, so you atleast have a chance of understanding what these numbers are about.
Yours, Linus Walleij
| |