Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 5/8] dmaengine: ste_dma40: Ensure src and dst registers are configured correctly | Date | Tue, 9 Apr 2013 20:57:29 +0200 |
| |
On Tuesday 09 April 2013, Lee Jones wrote: > Confusingly d40_log_cfg() is used to set up the logical channel > configuration registers, but d40_phy_cfg() is used to configure > physical and logical registers, so it should be called in both > cases. It is the function call's final attribute which determines > whether it's a physical or logical channel, not whether the > function is called or not.
So how did it ever work? Your description sounds like it was broken all along, but I would assume that someone tested the code.
Arnd
| |