| Date | Fri, 22 Mar 2013 11:37:30 -0700 | From | Dave <> | Subject | Re: [PATCHv2, RFC 21/30] x86-64, mm: proper alignment mappings with hugepages |
| |
On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > + if (filp) > + info.align_mask = mapping_can_have_hugepages(filp->f_mapping) ? > + PAGE_MASK & ~HPAGE_MASK : get_align_mask(); > + else > + info.align_mask = 0; > info.align_offset = pgoff << PAGE_SHIFT; > return vm_unmapped_area(&info); > } > @@ -174,7 +179,11 @@ arch_get_unmapped_area_topdown(struct file *filp, const unsigned long addr0, > info.length = len; > info.low_limit = PAGE_SIZE; > info.high_limit = mm->mmap_base; > - info.align_mask = filp ? get_align_mask() : 0; > + if (filp) > + info.align_mask = mapping_can_have_hugepages(filp->f_mapping) ? > + PAGE_MASK & ~HPAGE_MASK : get_align_mask(); > + else > + info.align_mask = 0; > info.align_offset = pgoff << PAGE_SHIFT; > addr = vm_unmapped_area(&info); > if (!(addr & ~PAGE_MASK))
how about
static inline unsigned long mapping_align_mask(struct address_space *mapping) { if (mapping_can_have_hugepages(filp->f_mapping)) return PAGE_MASK & ~HPAGE_MASK; return get_align_mask(); }
to replace these two open-coded versions?
|