lkml.org 
[lkml]   [2013]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHv2, RFC 25/30] thp, mm: basic huge_fault implementation for generic_file_vm_ops
Date
Hillf Danton wrote:
> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov
> <kirill.shutemov@linux.intel.com> wrote:
> >
> > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> > +static int filemap_huge_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
> > +{
> > + struct file *file = vma->vm_file;
> > + struct address_space *mapping = file->f_mapping;
> > + struct inode *inode = mapping->host;
> > + pgoff_t size, offset = vmf->pgoff;
> > + unsigned long address = (unsigned long) vmf->virtual_address;
> > + struct page *page;
> > + int ret = 0;
> > +
> > + BUG_ON(((address >> PAGE_SHIFT) & HPAGE_CACHE_INDEX_MASK) !=
> > + (offset & HPAGE_CACHE_INDEX_MASK));
> > +
> > +retry:
> > + page = find_get_page(mapping, offset);
> > + if (!page) {
> > + gfp_t gfp_mask = mapping_gfp_mask(mapping) | __GFP_COLD;
> > + page = alloc_pages(gfp_mask, HPAGE_PMD_ORDER);
> s/pages/pages_vma/ ?

Fixed. Thanks.

> > + if (!page) {
> > + count_vm_event(THP_FAULT_FALLBACK);
> > + return VM_FAULT_OOM;
> > + }

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2013-03-15 15:01    [W:0.909 / U:2.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site