| From | "Kirill A. Shutemov" <> | Subject | Re: [PATCHv2, RFC 08/30] thp, mm: rewrite add_to_page_cache_locked() to support huge pages | Date | Fri, 15 Mar 2013 15:23:33 +0200 (EET) |
| |
Hillf Danton wrote: > On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > <kirill.shutemov@linux.intel.com> wrote: > > + page_cache_get(page); > > + spin_lock_irq(&mapping->tree_lock); > > + page->mapping = mapping; > > + page->index = offset; > > + error = radix_tree_insert(&mapping->page_tree, offset, page); > > + if (unlikely(error)) > > + goto err; > > + if (PageTransHuge(page)) { > > + int i; > > + for (i = 1; i < HPAGE_CACHE_NR; i++) { > struct page *tail = page + i; to easy reader > > > + page_cache_get(page + i); > s/page_cache_get/get_page_foll/ ?
Why?
> > + page[i].index = offset + i; > > + error = radix_tree_insert(&mapping->page_tree, > > + offset + i, page + i); > > + if (error) { > > + page_cache_release(page + i); > > + break; > > + } > > } > > - radix_tree_preload_end(); > > - } else > > - mem_cgroup_uncharge_cache_page(page); > > -out: > > + if (error) { > > + error = ENOSPC; /* no space for a huge page */ > s/E/-E/
Good catch! Thanks.
> > + for (i--; i > 0; i--) { > > + radix_tree_delete(&mapping->page_tree, > > + offset + i); > > + page_cache_release(page + i); > > + } > > + radix_tree_delete(&mapping->page_tree, offset); > > + goto err; > > + } > > + }
-- Kirill A. Shutemov
|