lkml.org 
[lkml]   [2013]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHv2, RFC 09/30] thp, mm: rewrite delete_from_page_cache() to support huge pages
Date
Hillf Danton wrote:
> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov
> <kirill.shutemov@linux.intel.com> wrote:
> > + if (PageTransHuge(page)) {
> > + int i;
> > +
> > + for (i = 0; i < HPAGE_CACHE_NR; i++)
> > + radix_tree_delete(&mapping->page_tree, page->index + i);
>
> Move the below page_cache_release for tail page here, please.

Okay. Thanks.

> > + nr = HPAGE_CACHE_NR;
> [...]
> > + if (PageTransHuge(page))
> > + for (i = 1; i < HPAGE_CACHE_NR; i++)
> > + page_cache_release(page + i);
> > page_cache_release(page);

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2013-03-15 17:01    [W:1.853 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site