lkml.org 
[lkml]   [2013]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework
On 03/20/2013 05:23 AM, kishon wrote:
> Hi,
>
> On Monday 18 March 2013 05:59 PM, Venu Byravarasu wrote:
>> This patch updates all Tegra board files so that they contain all the
>> properties required by the updated USB DT binding. Note that this patch
>> only adds the new properties and does not yet remove the old properties,
>> in order to maintain bisectability. The old properties will be removed
>> once the driver has been updated to assume the new bindings.
>>
>> Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
>> ---
>> arch/arm/boot/dts/tegra20-colibri-512.dtsi | 4 +++
>> arch/arm/boot/dts/tegra20-harmony.dts | 8 +++---
>> arch/arm/boot/dts/tegra20-iris-512.dts | 4 +++
>> arch/arm/boot/dts/tegra20-paz00.dts | 8 +++---
>> arch/arm/boot/dts/tegra20-seaboard.dts | 13 +++++++---
>> arch/arm/boot/dts/tegra20-trimslice.dts | 12 +++++++---
>> arch/arm/boot/dts/tegra20-ventana.dts | 7 +++--
>> arch/arm/boot/dts/tegra20.dtsi | 32
>> +++++++++++++++++----------
>> 8 files changed, 57 insertions(+), 31 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
>> b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
>> index cb73e62..af5a7ae 100644
>> --- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
>> +++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
>> @@ -443,6 +443,10 @@
>> nvidia,phy-reset-gpio = <&gpio 169 0>; /* gpio PV1 */
>> };
>>
>> + usb-phy@c5004000 {
>
> This node doesn't have a *reg* property. So "@c5004000" is not needed.
> This comment applies to all the nodes which doesn't have *reg* property.

Yes it does have a reg property.

The node itself is first defined in tegra20.dtsi, and does contain a reg
property there.

tegra20-colibri-512.dtsi (and many other files in this patch) include
tegra20.dtsi, and simply add additional board-specific properties to the
existing node, and should not re-iterate properties that already exist.


\
 
 \ /
  Last update: 2013-03-20 19:21    [W:0.149 / U:1.976 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site