Messages in this thread | | | Date | Tue, 19 Mar 2013 13:58:31 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH 3/7] usb: phy: tegra: Get PHY mode using DT |
| |
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > Added a new PHY mode to support OTG. > Obtained Tegra USB PHY mode using DT property.
> diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c
> @@ -713,6 +712,16 @@ struct tegra_usb_phy *tegra_usb_phy_open(struct device *dev, int instance, > else > phy->is_ulpi_phy = true; > > + err = of_property_match_string(np, "dr_mode", "otg"); > + if (err < 0) { > + err = of_property_match_string(np, "dr_mode", "gadget"); > + if (err < 0)
The binding says the 3 legal values for this property are "host", "peripheral", or "otg". This agrees with the usage in Documentation/devicetree/bindings/usb/fsl-usb.txt and drivers/usb/host/fsl-mph-dr-of.c. So, "gadget" is not something the code should be checking for.
I'm sure I pointed this out before.
| |