| Date | Tue, 19 Mar 2013 14:10:07 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH 6/7] usb: phy: tegra: Add error handling & clean up. |
| |
On 03/18/2013 06:29 AM, Venu Byravarasu wrote: > Check return values from all GPIO APIs and handle errors accordingly.
> Remove clk_disable_unprepare which is no more needed.
The call to clk_disable_unprepare is incorrect in the current code. The way you worded that, it sounds like it's no longer needed because of the changes made in this patch. I would re-write that last sentence as:
Remove the call to clk_disable_unprepare(); this function does not prepare or enable the clock, so the error path should not disable or unprepare it.
|