| Subject | Re: [PATCH 03/16] wl1251: add sysfs interface for bluetooth coexistence mode configuration | From | Luca Coelho <> | Date | Tue, 29 Oct 2013 09:09:25 +0200 |
| |
On Mon, 2013-10-28 at 23:39 +0000, Ben Hutchings wrote: > On Sat, 2013-10-26 at 22:34 +0200, Pali Rohár wrote: > > From: David Gnedt <david.gnedt@davizone.at> > > > > Port the bt_coex_mode sysfs interface from wl1251 driver version included > > in the Maemo Fremantle kernel to allow bt-coexistence mode configuration. > > This enables userspace applications to set one of the modes > > WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO. > > The default mode is WL1251_BT_COEX_OFF. > > It should be noted that this driver always enabled bt-coexistence before > > and enabled bt-coexistence directly affects the receiving performance, > > rendering it unusable in some low-signal situations. Especially monitor > > mode is affected very badly with bt-coexistence enabled. > [...] > > This should be implemented consistently with other drivers: > > drivers/net/wireless/ath/ath9k/htc_drv_init.c:module_param_named(btcoex_enable, ath9k_htc_btcoex_enable, int, 0444); > drivers/net/wireless/ath/ath9k/init.c:module_param_named(btcoex_enable, ath9k_btcoex_enable, int, 0444); > drivers/net/wireless/b43/main.c:module_param_named(btcoex, modparam_btcoex, int, 0444); > drivers/net/wireless/ipw2x00/ipw2200.c:module_param(bt_coexist, int, 0444); > drivers/net/wireless/iwlegacy/common.c:module_param(bt_coex_active, bool, S_IRUGO); > drivers/net/wireless/iwlwifi/iwl-drv.c:module_param_named(bt_coex_active, iwlwifi_mod_params.bt_coex_active, > drivers/net/wireless/ti/wlcore/sysfs.c:static DEVICE_ATTR(bt_coex_state, S_IRUGO | S_IWUSR, > > Oh, hmm, I see a problem here.
With so many drivers doing the same thing, isn't it about time to add this to nl80211?
-- Luca.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|