lkml.org 
[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 04/16] wl1251: implement hardware ARP filtering
    Hi!

    > Update hardware ARP filter configuration on BSS_CHANGED_ARP_FILTER
    > notification from mac80211.
    > Ported from wl1271 driver.
    >
    > Signed-off-by: David Gnedt <david.gnedt@davizone.at>
    > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
    > ---
    > drivers/net/wireless/ti/wl1251/acx.c | 26 ++++++++++++++++++++++++++
    > drivers/net/wireless/ti/wl1251/acx.h | 15 +++++++++++++++
    > drivers/net/wireless/ti/wl1251/main.c | 12 ++++++++++++
    > 3 files changed, 53 insertions(+)
    >
    > diff --git a/drivers/net/wireless/ti/wl1251/acx.c b/drivers/net/wireless/ti/wl1251/acx.c
    > index cce50e2..5f4a552 100644
    > --- a/drivers/net/wireless/ti/wl1251/acx.c
    > +++ b/drivers/net/wireless/ti/wl1251/acx.c
    > @@ -1062,6 +1062,32 @@ out:
    > return ret;
    > }
    >
    > +int wl1251_acx_arp_ip_filter(struct wl1251 *wl, bool enable, __be32 address)
    > +{
    > + struct wl1251_acx_arp_filter *acx;
    > + int ret;

    Is it good idea to use be32 for IP address? AFAICT IPv4 addresses
    really don't have edianity. Perhaps u32 is better?

    > + if (enable)
    > + memcpy(acx->address, &address, ACX_IPV4_ADDR_SIZE);

    acx->address is an array of u8, so no endianity there, either.
    Pavel
    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-12-10 11:41    [W:4.404 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site