| Date | Tue, 10 Dec 2013 10:59:37 +0100 | From | Michal Kubecek <> | Subject | Re: [PATCH v2 04/16] wl1251: implement hardware ARP filtering |
| |
On Tue, Dec 10, 2013 at 10:29:16AM +0100, Pavel Machek wrote: > > > > +int wl1251_acx_arp_ip_filter(struct wl1251 *wl, bool enable, __be32 address) > > +{ > > + struct wl1251_acx_arp_filter *acx; > > + int ret; > > Is it good idea to use be32 for IP address? AFAICT IPv4 addresses > really don't have edianity. Perhaps u32 is better?
If they are known to be in network byte ordering, they do (as NBO is the same as BE).
Michal Kubecek
|