| Date | Fri, 11 Jan 2013 10:32:19 +0530 | From | Preeti U Murthy <> | Subject | Re: [PATCH v3 04/22] sched: don't need go to smaller sched domain |
| |
On 01/05/2013 02:07 PM, Alex Shi wrote: > If parent sched domain has no task allowed cpu find. neither find in > it's child. So, go out to save useless checking. > > Signed-off-by: Alex Shi <alex.shi@intel.com> > --- > kernel/sched/fair.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 3c7b09a..ecfbf8e 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -3378,10 +3378,8 @@ select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags) > load_idx = sd->wake_idx; > > group = find_idlest_group(sd, p, cpu, load_idx); > - if (!group) { > - sd = sd->child; > - continue; > - } > + if (!group) > + goto unlock; > > new_cpu = find_idlest_cpu(group, p, cpu); > Reviewed-by:Preeti U Murthy
|