lkml.org 
[lkml]   [2013]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 11/22] sched: consider runnable load average in effective_load
    Date
    effective_load calculates the load change as seen from the
    root_task_group. It needs to multiple cfs_rq's tg_runnable_contrib
    when we turn to runnable load average balance.

    Signed-off-by: Alex Shi <alex.shi@intel.com>
    ---
    kernel/sched/fair.c | 11 ++++++++---
    1 file changed, 8 insertions(+), 3 deletions(-)

    diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    index cab62aa..247d6a8 100644
    --- a/kernel/sched/fair.c
    +++ b/kernel/sched/fair.c
    @@ -2982,7 +2982,8 @@ static void task_waking_fair(struct task_struct *p)

    #ifdef CONFIG_FAIR_GROUP_SCHED
    /*
    - * effective_load() calculates the load change as seen from the root_task_group
    + * effective_load() calculates the runnable load average change as seen from
    + * the root_task_group
    *
    * Adding load to a group doesn't make a group heavier, but can cause movement
    * of group shares between cpus. Assuming the shares were perfectly aligned one
    @@ -3030,13 +3031,17 @@ static void task_waking_fair(struct task_struct *p)
    * Therefore the effective change in loads on CPU 0 would be 5/56 (3/8 - 2/7)
    * times the weight of the group. The effect on CPU 1 would be -4/56 (4/8 -
    * 4/7) times the weight of the group.
    + *
    + * After get effective_load of the load moving, will multiple the cpu own
    + * cfs_rq's runnable contrib of root_task_group.
    */
    static long effective_load(struct task_group *tg, int cpu, long wl, long wg)
    {
    struct sched_entity *se = tg->se[cpu];

    if (!tg->parent) /* the trivial, non-cgroup case */
    - return wl;
    + return wl * tg->cfs_rq[cpu]->tg_runnable_contrib
    + >> NICE_0_SHIFT;

    for_each_sched_entity(se) {
    long w, W;
    @@ -3084,7 +3089,7 @@ static long effective_load(struct task_group *tg, int cpu, long wl, long wg)
    wg = 0;
    }

    - return wl;
    + return wl * tg->cfs_rq[cpu]->tg_runnable_contrib >> NICE_0_SHIFT;
    }
    #else

    --
    1.7.12


    \
     
     \ /
      Last update: 2013-01-05 10:21    [W:2.972 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site