lkml.org 
[lkml]   [2012]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [ 080/262] usb: gadget: dummy_hcd: fixup error probe path
From
Date
On Fri, 2012-09-28 at 11:50 -0700, Greg Kroah-Hartman wrote:
> From: Greg KH <gregkh@linuxfoundation.org>
>
> 3.5-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
>
> commit 1b68a4ca2d038addb7314211d122fb6d7002b38b upstream.
>
> If USB2 host controller probes fine but USB3 does not then we don't
> remove the USB controller properly and lock up the system while the HUB
> code will try to enumerate the USB2 controller and access memory which
> is no longer available in case the dummy_hcd was compiled as a module.
>
> This is a problem since 448b6eb1 ("USB: Make sure to fetch the BOS desc
> for roothubs.) if used in USB3 mode because dummy does not provide this
> descriptor and explodes later.
[...]

i.e. for 3.5 (as noted in the cc: stable line). But I don't see why
this isn't needed for earlier kernel versions. The same broken error
handling is present.

Ben.

--
Ben Hutchings
Usenet is essentially a HUGE group of people passing notes in class.
- Rachel Kadel, `A Quick Guide to Newsgroup Etiquette'
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-09-29 21:41    [W:0.803 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site