lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 062/262] staging: r8712u: fix bug in r8712_recv_indicatepkt()
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.5-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Eric Dumazet <edumazet@google.com>

    commit abf02cfc179bb4bd30d05f582d61b3b8f429b813 upstream.

    64bit arches have a buggy r8712u driver, let's fix it.

    skb->tail must be set properly or network stack behavior is undefined.

    Addresses https://bugzilla.redhat.com/show_bug.cgi?id=847525
    Addresses https://bugzilla.kernel.org/show_bug.cgi?id=45071

    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Cc: Dave Jones <davej@redhat.com>
    Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/rtl8712/recv_linux.c | 7 +------
    1 file changed, 1 insertion(+), 6 deletions(-)

    --- a/drivers/staging/rtl8712/recv_linux.c
    +++ b/drivers/staging/rtl8712/recv_linux.c
    @@ -117,13 +117,8 @@ void r8712_recv_indicatepkt(struct _adap
    if (skb == NULL)
    goto _recv_indicatepkt_drop;
    skb->data = precv_frame->u.hdr.rx_data;
    -#ifdef NET_SKBUFF_DATA_USES_OFFSET
    - skb->tail = (sk_buff_data_t)(precv_frame->u.hdr.rx_tail -
    - precv_frame->u.hdr.rx_head);
    -#else
    - skb->tail = (sk_buff_data_t)precv_frame->u.hdr.rx_tail;
    -#endif
    skb->len = precv_frame->u.hdr.len;
    + skb_set_tail_pointer(skb, skb->len);
    if ((pattrib->tcpchk_valid == 1) && (pattrib->tcp_chkrpt == 1))
    skb->ip_summed = CHECKSUM_UNNECESSARY;
    else



    \
     
     \ /
      Last update: 2012-09-28 22:41    [W:4.021 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site