lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 019/262] l2tp: fix info leak via getsockname()
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.5-stable review patch. If anyone has any objections, please let me know.

    ------------------


    From: Mathias Krause <minipli@googlemail.com>

    [ Upstream commit 04d4fbca1017c11381e7d82acea21dd741e748bc ]

    The L2TP code for IPv6 fails to initialize the l2tp_unused member of
    struct sockaddr_l2tpip6 and that for leaks two bytes kernel stack via
    the getsockname() syscall. Initialize l2tp_unused with 0 to avoid the
    info leak.

    Signed-off-by: Mathias Krause <minipli@googlemail.com>
    Cc: James Chapman <jchapman@katalix.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/l2tp/l2tp_ip6.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/l2tp/l2tp_ip6.c
    +++ b/net/l2tp/l2tp_ip6.c
    @@ -410,6 +410,7 @@ static int l2tp_ip6_getname(struct socke
    lsa->l2tp_family = AF_INET6;
    lsa->l2tp_flowinfo = 0;
    lsa->l2tp_scope_id = 0;
    + lsa->l2tp_unused = 0;
    if (peer) {
    if (!lsk->peer_conn_id)
    return -ENOTCONN;



    \
     
     \ /
      Last update: 2012-09-28 21:41    [W:3.157 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site