lkml.org 
[lkml]   [2012]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 037/262] cciss: fix handling of protocol error
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.5-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>

    commit 2453f5f992717251cfadab6184fbb3ec2f2e8b40 upstream.

    If a command completes with a status of CMD_PROTOCOL_ERR, this
    information should be conveyed to the SCSI mid layer, not dropped
    on the floor. Unlike a similar bug in the hpsa driver, this bug
    only affects tape drives and CD and DVD ROM drives in the cciss
    driver, and to induce it, you have to disconnect (or damage) a
    cable, so it is not a very likely scenario (which would explain
    why the bug has gone undetected for the last 10 years.)

    Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/block/cciss_scsi.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/block/cciss_scsi.c
    +++ b/drivers/block/cciss_scsi.c
    @@ -795,6 +795,7 @@ static void complete_scsi_command(Comman
    }
    break;
    case CMD_PROTOCOL_ERR:
    + cmd->result = DID_ERROR << 16;
    dev_warn(&h->pdev->dev,
    "%p has protocol error\n", c);
    break;



    \
     
     \ /
      Last update: 2012-09-28 22:01    [W:3.189 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site