Messages in this thread | | | From | "Liu, Chuansheng" <> | Subject | RE: [PATCH] x86/fixup_irq: Clean the offlining CPU from the irq affinity mask | Date | Wed, 26 Sep 2012 08:10:04 +0000 |
| |
> Btw, on a slightly different note, I'm also rather surprised that the above > code doesn't care about the return value of chip->irq_set_affinity() .. > Shouldn't we warn if that fails?
It seems another case when irq_set_affinity is NULL whenever affinity is changed or not before that, For this case, I suppose the chip is not supporting set_affinity, then the chip should set all related irqs into just CPU0, otherwise, it will bring some trouble, do you agree?
I guess this case should be covered outside fixup_irqs() code.
| |